-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update python drivers (options) docs with code examples #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update python drivers (options) docs with code examples #1845
Conversation
Added/moved examples for python under the Drivers section
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
CLA assistant check
All committers have signed the CLA.
PR Reviewer Guide 🔍
Code Duplication
There is significant code duplication across multiple test functions. Each function sets up a WebDriver, navigates to a URL, and then quits. Consider refactoring to use a shared setup and teardown method or a context manager to reduce redundancy and improve maintainability.
Hardcoded Values
The URL 'http://www.google.com' is hardcoded in multiple test functions. Consider using a configuration file or environment variables to manage such values, making the tests more flexible and environment-independent.
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pmartinez1,
Thank you for the PR!
Can you switch to using "https://www.selenium.dev/" in all the code samples?
Thanks,
Sri
Thank you @pmartinez1!
Congratulations on your first contribution to Selenium Docs 🎉 🎉 🎉 !
...y site] * Update Ruby code-block to show .quit * Update python examples for Drivers - options docs Added/moved examples for python under the Drivers section * replace existing example url in python tests with selenium.dev --------- Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> bf2711a
Uh oh!
There was an error while loading. Please reload this page.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
This PR adds/moves code examples for python under the Drivers - options section of the site.
Motivation and Context
The examples should be helpful for those who are wanting to use Selenium.
Types of changes
Checklist
PR Type
Documentation, Enhancement
Description
examples/python/tests/drivers/test_options.py.gh-codeblockwith specific line references.Changes walkthrough 📝
1 files
test_options.py
Add comprehensive test cases for ChromeOptions settingsexamples/python/tests/drivers/test_options.py
rect, strict file interactability, and proxy settings.
8 files
_index.en.md
Update Python code examples with specific line referenceswebsite_and_docs/content/documentation/webdriver/drivers/_index.en.md
gh-codeblockwith specific linereferences.
_index.ja.md
Update Python code examples with specific line references (Japanese)website_and_docs/content/documentation/webdriver/drivers/_index.ja.md
gh-codeblockwith specific linereferences.
_index.pt-br.md
Update Python code examples with specific line references (Portuguese)website_and_docs/content/documentation/webdriver/drivers/_index.pt-br.md
gh-codeblockwith specific linereferences.
_index.zh-cn.md
Update Python code examples with specific line references (Chinese)website_and_docs/content/documentation/webdriver/drivers/_index.zh-cn.md
gh-codeblockwith specific linereferences.
options.en.md
Update Python options documentation with specific line referenceswebsite_and_docs/content/documentation/webdriver/drivers/options.en.md
gh-codeblockwith specific linereferences.
options.ja.md
Update Python options documentation with specific line references(Japanese)website_and_docs/content/documentation/webdriver/drivers/options.ja.md
gh-codeblockwith specific linereferences.
options.pt-br.md
Update Python options documentation with specific line references(Portuguese)website_and_docs/content/documentation/webdriver/drivers/options.pt-br.md
gh-codeblockwith specific linereferences.
options.zh-cn.md
Update Python options documentation with specific line references(Chinese)website_and_docs/content/documentation/webdriver/drivers/options.zh-cn.md
gh-codeblockwith specific linereferences.